Skip to content

Conversation

@pow2clk
Copy link

@pow2clk pow2clk commented Nov 13, 2024

the -undefined suppress option for Apple's linker is deprecated and was producing multiple warnings. This updates it to dynamic_lookup, which has much the same effect, but avoids these deprecation warnings.

the -undefined suppress option for Apple's linker is deprecated and was producing multiple warnings. This updates it to dynamic_lookup, which has much the same effect, but avoids these deprecation warnings.
@llvm-beanz llvm-beanz requested a review from cooperp November 13, 2024 22:31
@llvm-beanz
Copy link
Collaborator

@lgerbarg for comment/visibility.

Copy link
Contributor

@cooperp cooperp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pow2clk pow2clk marked this pull request as ready for review November 13, 2024 22:44
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Nov 13, 2024
@pow2clk pow2clk merged commit 1f0e0da into llvm:main Nov 14, 2024
12 checks passed
@pow2clk pow2clk deleted the apple_ld_undefined branch November 14, 2024 00:44
@pow2clk
Copy link
Author

pow2clk commented Nov 14, 2024

Thanks!

@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 14, 2024

LLVM Buildbot has detected a new failure on builder sanitizer-aarch64-linux-bootstrap-hwasan running on sanitizer-buildbot12 while building llvm at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/3547

Here is the relevant piece of the build log for the reference
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 83739 tests, 48 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
FAIL: lld :: ELF/linkerscript/overwrite-sections-discard.test (82187 of 83739)
******************** TEST 'lld :: ELF/linkerscript/overwrite-sections-discard.test' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: split-file /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/lld/test/ELF/linkerscript/overwrite-sections-discard.test /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp
+ split-file /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/lld/test/ELF/linkerscript/overwrite-sections-discard.test /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp
RUN: at line 3: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/llvm-mc -filetype=obj -triple=x86_64 /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.s -o /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.o
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/llvm-mc -filetype=obj -triple=x86_64 /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.s -o /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.o
RUN: at line 7: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/overwrite.lds -T /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/main.lds /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.o -o /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp1 2>&1 | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/count 0
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/overwrite.lds -T /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/main.lds /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.o -o /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp1
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/count 0
Expected 0 lines, got 1.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
119.85s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
109.24s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret-bfloat.c
81.48s: Clang :: CodeGen/X86/rot-intrinsics.c
81.30s: Clang :: CodeGen/X86/sse2-builtins.c
80.36s: Clang :: CodeGen/X86/avx-builtins.c
74.44s: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
69.20s: Clang :: Driver/fsanitize.c
67.95s: Clang :: Analysis/runtime-regression.c
60.69s: Clang :: CodeGen/X86/fma-builtins-constrained.c
60.32s: Clang :: CodeGen/X86/x86_64-xsave.c
59.92s: Clang :: CodeGen/X86/sse42-builtins.c
58.50s: Clang :: CodeGen/X86/avx2-builtins.c
56.24s: Clang :: Driver/arm-cortex-cpus-2.c
56.24s: Clang :: CodeGen/X86/sse41-builtins.c
56.18s: Clang :: CodeGen/X86/sse-builtins-constrained.c
55.87s: Clang :: Driver/arm-cortex-cpus-1.c
55.11s: Clang :: CodeGen/X86/mmx-builtins.c
48.27s: Clang :: Headers/arm-neon-header.c
Step 10 (stage2/hwasan check) failure: stage2/hwasan check (failure)
...
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using lld-link: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/lld-link
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using ld64.lld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld64.lld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/llvm/config.py:506: note: using wasm-ld: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/wasm-ld
llvm-lit: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/utils/lit/lit/main.py:72: note: The test suite configuration requested an individual test timeout of 0 seconds but a timeout of 900 seconds was requested on the command line. Forcing timeout to be 900 seconds.
-- Testing: 83739 tests, 48 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
FAIL: lld :: ELF/linkerscript/overwrite-sections-discard.test (82187 of 83739)
******************** TEST 'lld :: ELF/linkerscript/overwrite-sections-discard.test' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 2: split-file /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/lld/test/ELF/linkerscript/overwrite-sections-discard.test /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp
+ split-file /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/lld/test/ELF/linkerscript/overwrite-sections-discard.test /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp
RUN: at line 3: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/llvm-mc -filetype=obj -triple=x86_64 /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.s -o /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.o
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/llvm-mc -filetype=obj -triple=x86_64 /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.s -o /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.o
RUN: at line 7: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/overwrite.lds -T /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/main.lds /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.o -o /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp1 2>&1 | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/count 0
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/ld.lld /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/overwrite.lds -T /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/main.lds /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp/a.o -o /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/tools/lld/test/ELF/linkerscript/Output/overwrite-sections-discard.test.tmp1
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/count 0
Expected 0 lines, got 1.

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Slowest Tests:
--------------------------------------------------------------------------
119.85s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret.c
109.24s: Clang :: CodeGen/AArch64/sve-intrinsics/acle_sve_reinterpret-bfloat.c
81.48s: Clang :: CodeGen/X86/rot-intrinsics.c
81.30s: Clang :: CodeGen/X86/sse2-builtins.c
80.36s: Clang :: CodeGen/X86/avx-builtins.c
74.44s: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
69.20s: Clang :: Driver/fsanitize.c
67.95s: Clang :: Analysis/runtime-regression.c
60.69s: Clang :: CodeGen/X86/fma-builtins-constrained.c
60.32s: Clang :: CodeGen/X86/x86_64-xsave.c
59.92s: Clang :: CodeGen/X86/sse42-builtins.c
58.50s: Clang :: CodeGen/X86/avx2-builtins.c
56.24s: Clang :: Driver/arm-cortex-cpus-2.c
56.24s: Clang :: CodeGen/X86/sse41-builtins.c
56.18s: Clang :: CodeGen/X86/sse-builtins-constrained.c
55.87s: Clang :: Driver/arm-cortex-cpus-1.c
55.11s: Clang :: CodeGen/X86/mmx-builtins.c
48.27s: Clang :: Headers/arm-neon-header.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake Build system in general and CMake in particular

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants